[dpdk-dev] [PATCH v6 6/9] test: dynamic rss configuration

Thomas Monjalon thomas.monjalon at 6wind.com
Tue Oct 27 18:34:11 CET 2015


This new test depends on null PMD.
The dependency should be checked gracefully, see below.

2015-10-16 12:00, Tomasz Kulasek:
> --- a/app/test/Makefile
> +++ b/app/test/Makefile
> @@ -138,6 +138,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_ACL) += test_acl.c
>  ifeq ($(CONFIG_RTE_LIBRTE_PMD_RING),y)
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += test_link_bonding.c
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += test_link_bonding_mode4.c

Why not enclose in ifeq ($(CONFIG_RTE_LIBRTE_PMD_NULL),y)?

> +SRCS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += test_link_bonding_rssconf.c
>  endif
>  
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_RING) += test_pmd_ring.c
> @@ -168,6 +169,13 @@ ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
>  LDLIBS += -lrte_pmd_ring
>  endif
>  endif
> +ifneq ($(CONFIG_RTE_LIBRTE_PMD_NULL),y)
> +$(error Link bonding rssconf tests require CONFIG_RTE_LIBRTE_PMD_NULL=y)

Not needed if handled as suggested above.
The build should not fail because a module is disabled.

> +else
> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
> +LDLIBS += -lrte_pmd_null
> +endif
> +endif



More information about the dev mailing list