[dpdk-dev] [PATCH v2 4/6] i40e: add additional ieee1588 support functions

[De Lara Guarch, Pablo]

Hi Konstantin,

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ananyev,
> Konstantin
> Sent: Friday, October 30, 2015 11:20 AM
> To: Mrzyglod, DanielX T; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 4/6] i40e: add additional ieee1588 support
> functions
> 
> Hi Daniel,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Daniel Mrzyglod
> > Sent: Friday, October 30, 2015 9:43 AM
> > To: dev at dpdk.org
> > Subject: [dpdk-dev] [PATCH v2 4/6] i40e: add additional ieee1588 support
> functions
> >
> > From: Pablo de Lara <pablo.de.lara.guarch at intel.com>
> >
> > Add additional functions to support the existing IEEE1588
> > functionality and to enable getting, setting and adjusting
> > the device time.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
> > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod at intel.com>

[...]

> 
> These 3 functions above are redefined for each PMD in your patch.
> I think it is worth to move it to the upper layer (rte_ethdev, rte_net) to avoid
> code duplication.
> Thanks
> Kinstantin

We thought about that, but we didn't know what the best place was for them.
Looking at the functions in rte_ethdev, they look quite different compared to these ones,
so we thought it wasn't the appropriate place. Do you think that is the best place?

Thanks,
Pablo