[dpdk-dev] [PATCH v2 4/6] i40e: add additional ieee1588 support functions

Thomas Monjalon thomas.monjalon at 6wind.com
Fri Oct 30 12:36:47 CET 2015


2015-10-30 11:33, De Lara Guarch, Pablo:
> > These 3 functions above are redefined for each PMD in your patch.
> > I think it is worth to move it to the upper layer (rte_ethdev, rte_net) to avoid
> > code duplication.
> > Thanks
> > Kinstantin
> 
> We thought about that, but we didn't know what the best place was for them.
> Looking at the functions in rte_ethdev, they look quite different compared to these ones,
> so we thought it wasn't the appropriate place. Do you think that is the best place?

You are talking about the timer conversions, right?
It looks appropriate for EAL.


More information about the dev mailing list