[dpdk-dev] [PATCH v2 3/6] eal/arm: add 64-bit armv8 version of rte_cycles.h

[Hunt, David]

On 30/10/2015 12:44, Jan Viktorin wrote:
> On Fri, 30 Oct 2015 11:51:23 +0000
> David Hunt <david.hunt at intel.com> wrote:
>
>> +static inline uint64_t
>> +rte_rdtsc(void)
>> +{
>> +	uint64_t tsc;
>> +
>> +	asm volatile("mrs %0, CNTVCT_EL0" : "=r" (tsc));
>> +
>> +#ifdef RTE_TIMER_MULTIPLIER
>> +	return tsc * RTE_TIMER_MULTIPLIER;
>> +#else
>
> I think, this should be CONFIG_RTE_TIMER_MULTIPLIER.
>
> Jan

Jan,
     Thanks for the super-fast review :)

     I've taken a look at this and RTE_TIMER_MULTIPLIER is present in 
the generated include/rte_config.h, so it compiles and run fine. I've 
also confirmed this by removing the #ifdef, forcing the use of 
RTE_TIMER_MULTIPLIER as a test.
Dave.