[dpdk-dev] [PATCH] ixgbe: Out-by-one in get/set EEPROM

Thomas Monjalon thomas.monjalon at 6wind.com
Wed Sep 16 15:23:39 CEST 2015


2015-09-16 14:07, Remy Horton:
> Incorrect operator in ixgbe_get_eeprom & ixgbe_set_eeprom prevents
> last byte of EEPROM being read/written, and hence cannot be dumped
> or updated in entirity using these functions.

This explanation is good but the title is not clear enough. It should
start with "ixgbe: fix". Fix what? I'd say "fix access to last byte of EEPROM".
Then creating a commit starting with "fix" should trigger 2 other things:
	- a Fixes: tag
	- an update in the release notes (because the bug exists in previous releases)

Thanks


More information about the dev mailing list