[dpdk-dev] [PATCH v2] hash: rename unused field to "reserved"

Stephen Hemminger stephen at networkplumber.org
Wed Sep 23 01:01:57 CEST 2015


On Mon, 13 Jul 2015 17:38:45 +0100
Bruce Richardson <bruce.richardson at intel.com> wrote:

> The cuckoo hash has a fixed number of entries per bucket, so the
> configuration parameter for this is unused. We change this field in the
> parameters struct to "reserved" to indicate that there is now no such
> parameter value, while at the same time keeping ABI consistency.
> 
> Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation")
> 
> Suggested-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>

I am sorry this patch went into 2.1 because it broke source code
compatibility.  To me having source code recompile compatibility is MORE
important than ABI compatibility.


More information about the dev mailing list