[dpdk-dev] [PATCH v3 0/4] fix creation of duplicate lpm and hash

Thomas Monjalon thomas.monjalon at 6wind.com
Tue Apr 5 17:51:44 CEST 2016


2016-04-05 13:53, Olivier Matz:
> Seen while trying to fix the func_reentrancy autotest. The
> series addresses several issues:
> 
> 1/ Hash and lpm return a pointer to an existing object if the user requests the
>    creation with an already existing name. This look dangerous: when an object
>    is returned, the user does not know if it should be freed or not.
> 
> 2/ There is a race condition in cuckoo_hash as the lock is not held in
>    rte_hash_create(). We could find some cases where NULL is returned when the
>    object already exists (ex: when rte_ring_create() fails).
> 
> 3/ There is a race condition func_reentrancy that can fail even if the tested
>    API behaves correctly.

Pablo, Bruce,
What do you think of these fixes for 16.04?


More information about the dev mailing list