[dpdk-dev] [PATCH v13 4/8] ethdev: rename link speed constants

[Thomas Monjalon]

2016-04-06 09:16, Weglicki, MichalX:
> Hello, 
> 
> Thank you for your answer. 
> 
> I didn't mention that patch is cosmetic, rather naming. 
> 
> But all clear, I somehow missed it 9 months ago, and couldn't find it. 
> 
> Is there any official place where I can find upcoming ABI & API changes, or I have to dig through mailing list? 

Yes, the API and ABI changes are described in the release notes:
	http://dpdk.org/browse/dpdk/tree/doc/guides/rel_notes/release_16_04.rst#n471
And the next deprecations are announced in another section:
	http://dpdk.org/browse/dpdk/tree/doc/guides/rel_notes/deprecation.rst

PS: please answer inline

-----------------
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] 
> 2016-04-06 08:34, Weglicki, MichalX:
> > Hello, 
> > 
> > I have a question about this patch. 
> > 
> > As far as I see changing ETH_LINK_SPEED_ to ETH_SPEED_NUM_ is rather cosmetic change, am I right? 
> 
> No.
> ETH_LINK_SPEED was used for configuration and reported speed.
> Now the configuration is done with a bitmap filled with new ETH_LINK_SPEED
> and the old numerical values are kept for other usages as ETH_SPEED_NUM.
> 
> > Disadvantage of that is that it breaks compatibility with OVS (compilation) and thus it also breaks backward compatibility between OVS & DPDK. Is it really necessary? 
> 
> Yes that's why this change was discussed 9 months ago and announced in the
> previous release notes.
> 
> > It would be great to keep ABI & API stable if possible.
> 
> We try to keep it stable when possible and continue to bring some improvements.