[dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get
Rasesh Mody
rasesh.mody at qlogic.com
Thu Apr 7 07:10:38 CEST 2016
> From: Van Haaren, Harry [mailto:harry.van.haaren at intel.com]
> Sent: Wednesday, April 06, 2016 7:33 AM
>
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Rasesh Mody
> > Subject: [dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get
>
> Hi Rasesh,
>
> > + snprintf(xstats[num].name, sizeof(xstats[num].name),
> "brb_drops");
>
> I don't understand what a "brb" drop is.
>
>
> > + snprintf(xstats[num].name, sizeof(xstats[num].name), "tx_pfc");
>
> Similarly here, and with some other of the xstats strings, it doesn't become
> clear to me what exactly the value represents.
>
> "mac_filter_discard" is descriptive and readable, but the next stat has
> "mf_tag_discard" - these small inconsistencies make it much harder
> (impossible?) to scrap the xstats strings and retrieve useful metadata.
>
> I'll suggest leaving the xstats implementation part of this patch until the next
> release, and we can align on the names of the stats.
We'll re-work the patch to accommodate your suggestions.
>
> -Harry
More information about the dev
mailing list