[dpdk-dev] [PATCH v2] ivshmem: avoid infinite loop when concatenating adjacent segments

Thomas Monjalon thomas.monjalon at 6wind.com
Thu Apr 7 19:18:21 CEST 2016


> This patch aligns the logic used to check for the presence of
> adjacent segments in has_adjacent_segments() with the logic used
> in cleanup_segments() when actually deciding to concatenate or
> not a pair of segments. Additionally, adjacent segments are
> no longer considered overlapping to avoid generating errors for
> segments that can happily coexist together.
> 
> This fixes an infinite loop that happened when segments where
> adjacent in their physical or virtual addresses but not in their
> ioremap addresses: has_adjacent_segments() reported the presence
> of adjacent segments while cleanup_segments() was not considering
> them for concatenation, resulting in an infinite loop since the
> result of has_adjacent_segments() is used in the decision to
> continue looping in cleanup_segments().
> 
> Signed-off-by: David Verbeiren <david.verbeiren at intel.com>
> Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>

Applied, thanks


More information about the dev mailing list