[dpdk-dev] [PATCH v4] examples/vm_power_manager: fix libvirt dependency check

Bruce Richardson bruce.richardson at intel.com
Mon Apr 11 12:37:23 CEST 2016


On Mon, Apr 11, 2016 at 12:32:52PM +0200, Thomas Monjalon wrote:
> From: Marvin Liu <yong.liu at intel.com>
> 
> vm_power_manager utilize libvirt API virDomainGetVcpuPinInfo to
> retrieve domU vcpu information. This API is implemented from version 0.9.3.
> Suse11 SP3 32bit default libvirt version is 0.8.8.
> 
> examples/vm_power_manager/channel_manager.c:
> channel_manager.c:117:3: error: implicit declaration of function
> ‘virDomainGetVcpuPinInfo’
> 
> Check and skip it from examples or raise an error when trying to compile
> without libvirt or with a too old libvirt.
> 
> Fixes: e8ae9b662 ("examples/vm_power: channel manager and monitor in host")
> 
> Signed-off-by: Marvin Liu <yong.liu at intel.com>
> Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
> ---
>  examples/Makefile                  | 4 ++++
>  examples/vm_power_manager/Makefile | 6 ++++++
>  2 files changed, 10 insertions(+)
> 
> v4: mix v2 and v3 to skip in examples list but raise an error if trying
>     to compile directly
> 
Yes, that is the correct way to fix it, I believe.

Acked-by: Bruce Richardson <bruce.richardson at intel.com>



More information about the dev mailing list