[dpdk-dev] [PATCH 10/36] mempool: use the list to iterate the mempool elements

Wiles, Keith keith.wiles at intel.com
Thu Apr 14 17:33:09 CEST 2016


>
> static void
>-txq_mp2mr_mbuf_check(void *arg, void *start, void *end,
>-		     uint32_t index __rte_unused)
>+txq_mp2mr_mbuf_check(struct rte_mempool *mp, void *arg, void *obj,
>+	__rte_unused uint32_t index)

I have seen this use of __rte_unused or attributes attached to variables and structures in couple different ways.

I have seen the placement of the attribute after and before the variable I prefer the attribute to be after, but could adapt I hope.
Do we have a rule about where the attribute is put in this case and others. I have seen the attributes for structures are always at the end of the structure, which is some cases it may not compile in other places.

I would like to suggest we place the attributes at the end of structure e.g. __rte_cached_aligned and I would like to see the __rte_unused after the variable as a style in the code.

Thanks

> {
> 	struct txq_mp2mr_mbuf_check_data *data = arg;
>-	struct rte_mbuf *buf =
>-		(void *)((uintptr_t)start + data->mp->header_size);
>
Regards,
Keith






More information about the dev mailing list