[dpdk-dev] [PATCH 14/36] mempool: store physaddr in mempool objects

[Wiles, Keith]

>Store the physical address of the object in its header. It simplifies
>rte_mempool_virt2phy() and prepares the removing of the paddr[] table
>in the mempool header.
>
>Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
>---
> lib/librte_mempool/rte_mempool.c | 17 +++++++++++------
> lib/librte_mempool/rte_mempool.h | 11 ++++++-----
> 2 files changed, 17 insertions(+), 11 deletions(-)
>
>diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
>index 839b828..b8e46fc 100644
>--- a/lib/librte_mempool/rte_mempool.c
>+++ b/lib/librte_mempool/rte_mempool.c
>@@ -132,19 +132,22 @@ static unsigned optimize_object_size(unsigned obj_size)
> typedef void (*rte_mempool_obj_iter_t)(void * /*obj_iter_arg*/,
> 	void * /*obj_start*/,
> 	void * /*obj_end*/,
>-	uint32_t /*obj_index */);
>+	uint32_t /*obj_index */,
>+	phys_addr_t /*physaddr*/);

What is the reason to comment out the variable names, if no reason I would suggest we remove the comment marks and leave the var names.
>

Regards,
Keith