[dpdk-dev] [PATCH 1/6] i40e: fix problematic dereference
Helin Zhang
helin.zhang at intel.com
Thu Apr 21 05:42:52 CEST 2016
Fix issue reported by Coverity.
Coverity ID 119267: Dereference before null check.
Fixes: 8e109464c022 ("i40e: allow vector Rx and Tx usage")
Signed-off-by: Helin Zhang <helin.zhang at intel.com>
---
drivers/net/i40e/i40e_rxtx.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 4d35d83..9c126a3 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -2592,14 +2592,14 @@ i40e_rx_queue_release_mbufs(struct i40e_rx_queue *rxq)
{
uint16_t i;
- /* SSE Vector driver has a different way of releasing mbufs. */
- if (rxq->rx_using_sse) {
- i40e_rx_queue_release_mbufs_vec(rxq);
+ if (!rxq || !rxq->sw_ring) {
+ PMD_DRV_LOG(DEBUG, "Pointer to rxq or sw_ring is NULL");
return;
}
- if (!rxq || !rxq->sw_ring) {
- PMD_DRV_LOG(DEBUG, "Pointer to rxq or sw_ring is NULL");
+ /* SSE Vector driver has a different way of releasing mbufs. */
+ if (rxq->rx_using_sse) {
+ i40e_rx_queue_release_mbufs_vec(rxq);
return;
}
--
2.5.0
More information about the dev
mailing list