[dpdk-dev] [PATCH 4/7] examples/vhost: use mac compare helper function directly

Yuanhan Liu yuanhan.liu at linux.intel.com
Tue Apr 26 06:45:48 CEST 2016


rte_ether.h already provides a helper function to do mac address
compare. No need to define our own, use it directly.

Signed-off-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>
---
 examples/vhost/main.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 092bb13..6cc34b7 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -104,9 +104,6 @@
 /* Maximum long option length for option parsing. */
 #define MAX_LONG_OPT_SZ 64
 
-/* Used to compare MAC addresses. */
-#define MAC_ADDR_CMP 0xFFFFFFFFFFFFULL
-
 /* mask of enabled ports */
 static uint32_t enabled_port_mask = 0;
 
@@ -734,15 +731,6 @@ static unsigned check_ports_num(unsigned nb_ports)
 #define PRINT_PACKET(device, addr, size, header) do{} while(0)
 #endif
 
-/*
- * Compares a packet destination MAC address to a device MAC address.
- */
-static inline int __attribute__((always_inline))
-ether_addr_cmp(struct ether_addr *ea, struct ether_addr *eb)
-{
-	return ((*(uint64_t *)ea ^ *(uint64_t *)eb) & MAC_ADDR_CMP) == 0;
-}
-
 static inline struct vhost_dev * __attribute__((always_inline))
 find_vhost_dev(struct ether_addr *mac)
 {
@@ -750,7 +738,7 @@ find_vhost_dev(struct ether_addr *mac)
 
 	TAILQ_FOREACH(vdev, &vhost_dev_list, next) {
 		if (vdev->ready == DEVICE_RX &&
-		    ether_addr_cmp(mac, &vdev->mac_address))
+		    is_same_ether_addr(mac, &vdev->mac_address))
 			return vdev;
 	}
 
-- 
1.9.0



More information about the dev mailing list