[dpdk-dev] [PATCH v6 1/8] qede: Add maintainers, documentation and license

Rasesh Mody rasesh.mody at qlogic.com
Tue Apr 26 21:35:43 CEST 2016


> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, April 26, 2016 12:34 PM
> 
> 2016-04-26 18:27, Rasesh Mody:
> > > From: Bruce Richardson [mailto:bruce.richardson at intel.com]
> > > Sent: Tuesday, April 26, 2016 6:03 AM
> > >
> > > On Mon, Apr 25, 2016 at 10:12:59PM -0700, Rasesh Mody wrote:
> > > > Signed-off-by: Harish Patil <harish.patil at qlogic.com>
> > > > Signed-off-by: Rasesh Mody <rasesh.mody at qlogic.com>
> > > > Signed-off-by: Sony Chacko <sony.chacko at qlogic.com>
> > > > ---
> > > >  MAINTAINERS                       |    7 +
> > > >  doc/guides/nics/index.rst         |    1 +
> > > >  doc/guides/nics/overview.rst      |   86 +++++-----
> > > >  doc/guides/nics/qede.rst          |  314
> > > +++++++++++++++++++++++++++++++++++++
> > > >  drivers/net/qede/LICENSE.qede_pmd |   28 ++++
> > > >  5 files changed, 393 insertions(+), 43 deletions(-)  create mode
> > > > 100644 doc/guides/nics/qede.rst  create mode 100644
> > > > drivers/net/qede/LICENSE.qede_pmd
> > > >
> > > > diff --git a/MAINTAINERS b/MAINTAINERS index 1953ea2..ba4053a
> > > > 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -332,6 +332,13 @@ M: Rasesh Mody <rasesh.mody at qlogic.com>
> > > >  F: drivers/net/bnx2x/
> > > >  F: doc/guides/nics/bnx2x.rst
> > > >
> > > > +QLogic qede PMD
> > > > +M: Harish Patil <harish.patil at qlogic.com>
> > > > +M: Rasesh Mody <rasesh.mody at qlogic.com>
> > > > +M: Sony Chacko <sony.chacko at qlogic.com>
> > > > +F: drivers/net/qede/
> > > > +F: doc/guides/nics/qede.rst
> > > > +
> > > >  RedHat virtio
> > > >  M: Huawei Xie <huawei.xie at intel.com>
> > > >  M: Yuanhan Liu <yuanhan.liu at linux.intel.com> diff --git
> > > > a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst index
> > > > 769f677..d67f056 100644
> > > > --- a/doc/guides/nics/index.rst
> > > > +++ b/doc/guides/nics/index.rst
> > > > @@ -53,6 +53,7 @@ Network Interface Controller Drivers
> > > >      vhost
> > > >      vmxnet3
> > > >      pcap_ring
> > > > +    qede
> > >
> > > Minor nit - this addition should be between "nfp" and "szedata2" as
> > > the list is in alphabetical order apart from the last entry which
> > > covers two virtual NICs in the one section.
> > >
> > > /Bruce
> >
> > During our v5 submission we received a comment to keep the logic order
> by adding qede below bnx2x, hence the change. We can place it under "nfp"
> and "szedata2" to maintain the alphabetical order.
> 
> I think you are talking of 2 different things:
> MAINTAINERS file et doc/guides/nics.
> For MAINTAINERS, this patch is right.
> For doc, it is not.

You are right, I overlooked it, will modify it.
Thanks!
Rasesh


More information about the dev mailing list