[dpdk-dev] [PATCH v3 2/2] virtio: fix memory leak of virtqueue memzones

Yuanhan Liu yuanhan.liu at linux.intel.com
Fri Apr 29 07:33:08 CEST 2016


On Fri, Apr 29, 2016 at 12:48:46AM +0000, Jianfeng Tan wrote:
> @@ -447,6 +453,7 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev,
>  
>  	hw->vtpci_ops->setup_queue(hw, vq);
>  
> +	vq->started = 1;

Judging that this is in the "_queue_setup" stage, and we have another
stage called "_dev_start", naming it to "started" seems confusing then.

So, how about naming it to something like "configured"? Besides that,
this patch set looks good to me. If you agree the name change, or have
better idea, I could fix it while applying it.

	--yliu


More information about the dev mailing list