[dpdk-dev] [PATCH] examples: fix unusual-interpreter
Thomas Monjalon
thomas.monjalon at 6wind.com
Mon Aug 1 15:26:15 CEST 2016
2016-08-01 15:12, Christian Ehrhardt:
> On Mon, Aug 1, 2016 at 2:50 PM, Thomas Monjalon <thomas.monjalon at 6wind.com>
> wrote:
> > 2016-08-01 14:28, Christian Ehrhardt:
> > > Due to regular lintian checks in Debian packaging it surfaced that these
> > > two scripts had a space in their #! statement which renders it to be
> > > human, but not shell readable.
> > [...]
> > > -#! /usr/bin/python2
> > > +#!/usr/bin/python2
> >
> > I think we can have a space in the shebang (it works with shells I know).
> > But maybe lintian do not like it (and it is a sufficient reason to accept
> > this trivial patch).
> >
> > However, a better fix would be to run something else than python2,
> > like /usr/bin/env python.
> >
> > Some other python scripts in tools dir may be fixed.
>
> I agree on both changes you suggested, but not being the scripts author I
> wanted to change as few as possible.
> Also thanks for taking it into consideration even if just for lintian :-)
>
> If acceptable to you I'd ask to accept this as-is and consider the patch a
> head-up for all script owners to change their headers.
We can remove the space in every scripts, at least.
Then we can wait a little for the opinion of the script authors to do
more changes.
PS: Please avoid top posting.
More information about the dev
mailing list