[dpdk-dev] [PATCH] ethdev: fix a typo in eth device API doc

Thomas Monjalon thomas.monjalon at 6wind.com
Wed Aug 24 18:06:26 CEST 2016


2016-08-01 11:19, Nikhil Rao:
> This patch fixes a typo in the eth device API doc, device
> config. not stored between calls to rte_eth_dev_start/stop()
> should be restored before a call to rte_eth_dev_start()
> instead of after a call to rte_eth_dev_start().
> 
> Signed-off-by: Nikhil Rao <nikhil.rao at intel.com>
[...]
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -118,7 +118,7 @@
>   *     - NIC queue statistics mappings
>   *
>   * Any other configuration will not be stored and will need to be re-entered
> - * after a call to rte_eth_dev_start().
> + * before a call to rte_eth_dev_start().

I have some doubts about this and above comment.
I think we should give move details in the comments of the functions,
instead of this (not often read) global comment.


More information about the dev mailing list