[dpdk-dev] [PATCH] fix to use index to HW queue assigned to PF instead of queus 0 - nb_rx_queues which belong to VF in SR-IOV configuration

Stephen Hemminger stephen at networkplumber.org
Fri Aug 26 17:57:10 CEST 2016


On Fri, 26 Aug 2016 11:55:40 +0100
Ferruh Yigit <ferruh.yigit at intel.com> wrote:

> Hi Alex,
> 
> On 8/26/2016 11:09 AM, azelezniak wrote:
> > From: Alex Zelezniak <alexz at att.com>
> > 
> > Signed-off-by: Alex Zelezniak <alexz at att.com>
> > ---  
> 
> Thank you for the patch, not related to the patch content but related to
> the patch format:
> patch subject is too long, it is expected to be around 50 characters,
> can you please move some of information to the patch commit log?
> 
> Also since this is a fix, commit log requires a Fixes line.
> 
> More details on:
> http://dpdk.org/doc/guides/contributing/patches.html#sending-patches
> 
> Thanks,
> ferruh
> 

The subject line of the patch email becomes the first line of the
git commit message. This also documented on 'git commit' man page.

DISCUSSION
       Though not required, it’s a good idea to begin the commit message with
       a single short (less than 50 character) line summarizing the change,
       followed by a blank line and then a more thorough description.

Overly long summary lines are flagged as errors by tools like Debian lintian.


More information about the dev mailing list