[dpdk-dev] [PATCH 31/31] i40e: enhance in sanity check of mac

[Ferruh Yigit]

On 12/2/2016 12:12 AM, Wenzhuo Lu wrote:
> When VF sends request to add a new mac address, PF host
> will check if it's a non-zero or uncast address, or it
> will return with error. In fact, VF still can set multicast
> address. This change remove to check if it's a unicast
> address.
> 
> Signed-off-by: Chen Jing D(Mark) <jing.d.chen at intel.com>
> ---

commit subject tag should be: "net/i40e:", and MAC is uppercase.

>  drivers/net/i40e/i40e_pf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c
> index 4b0da75..c9cca1e 100644
> --- a/drivers/net/i40e/i40e_pf.c
> +++ b/drivers/net/i40e/i40e_pf.c
> @@ -890,7 +890,7 @@
>  		mac = (struct ether_addr *)(addr_list->list[i].addr);
>  		(void)rte_memcpy(&filter.mac_addr, mac, ETHER_ADDR_LEN);
>  		filter.filter_type = RTE_MACVLAN_PERFECT_MATCH;
> -		if(!is_valid_assigned_ether_addr(mac) ||
> +		if(is_zero_ether_addr(mac) ||

checkpatch warning:
ERROR:SPACING: space required before the open parenthesis '('

>  			i40e_vsi_add_mac(vf->vsi, &filter)) {
>  			ret = I40E_ERR_INVALID_MAC_ADDR;
>  			goto send_msg;
>