[dpdk-dev] [PATCH 0/3] net: optimize Rx/Tx log message level

[Ferruh Yigit]

Hi Qiming,

On 12/3/2016 10:43 AM, Qiming Yang wrote:
> These three patches optimized the level of Rx and Tx log
> messages. Add a new log control function PMD_RX_FREE_LOG
> to control the Rx message which is not printed in packet
> receive processing. This function switched by macro 
> RTE_LIBRTE_<PMD>_DEBUG_RX_FREE.

Please CC the maintainers,

CC: Wenzhuo Lu <wenzhuo.lu at intel.com>
CC: Konstantin Ananyev <konstantin.ananyev at intel.com>, Helin Zhang
<helin.zhang at intel.com>
CC: Jingjing Wu <jingjing.wu at intel.com>

1- Do we really need a new config option just for this log function, we
already may have more config options?

2- Do we really need this new logging function at all? This is to report
when receive descriptor tail updated, as far as I can see. What is the
use case that makes this case so special?

3- Log level of some messages are increased, like mbuf allocation
failure message level increased to ERR, what is the expectation here? In
high throughput traffic this may cause lots of noise, and what user can
do with this message? If user can't do anything, why we bloating user
with error messages? There is already a dynamic counter, I believe which
is good thing to the for this error, and debug level logging.


Overall I am for rejecting this patchset, unless there is a good
justification for new debug log macro.

Thanks,
ferruh