[dpdk-dev] [PATCH 18/32] net/dpaa2: introducing dpaa2 pmd driver

[Hemant Agrawal]

On 12/7/2016 2:38 AM, Thomas Monjalon wrote:
> 2016-12-06 19:49, Ferruh Yigit:
>> On 12/4/2016 6:17 PM, Hemant Agrawal wrote:
>>> +	if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
>>> +		eth_dev->data->dev_private = rte_zmalloc(
>>> +						"ethdev private structure",
>>> +						eth_drv->dev_private_size,
>>> +						RTE_CACHE_LINE_SIZE);
>>> +		if (eth_dev->data->dev_private == NULL)
>>> +			rte_panic("Cannot allocate memzone for private port"
>>> +				  " data\n");
>>
>> Should this error kill all app, or return an error for this PMD that is
>> probed.
>
> It cannot be a question :)
> rte_panic() inside libs or drivers is forbidden (and existing ones must
> be removed).
>
I will change it to return an error.