[dpdk-dev] [PATCH v2] doc: introduce PVP reference benchmark

Mcnamara, John john.mcnamara at intel.com
Fri Dec 9 11:26:02 CET 2016



> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com]
> Sent: Friday, December 9, 2016 6:30 AM
> To: Mcnamara, John <john.mcnamara at intel.com>; yuanhan.liu at linux.intel.com;
> thomas.monjalon at 6wind.com; Yang, Zhiyong <zhiyong.yang at intel.com>;
> ktraynor at redhat.com; dev at dpdk.org
> Subject: Re: [PATCH v2] doc: introduce PVP reference benchmark
> 
> 
> 
> On 12/07/2016 10:07 PM, Mcnamara, John wrote:
> >> -----Original Message-----
> >> From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com]
> >> Sent: Tuesday, December 6, 2016 12:25 PM
> >> To: yuanhan.liu at linux.intel.com; thomas.monjalon at 6wind.com; Mcnamara,
> >> John <john.mcnamara at intel.com>; Yang, Zhiyong
> >> <zhiyong.yang at intel.com>; ktraynor at redhat.com; dev at dpdk.org
> >> Cc: Maxime Coquelin <maxime.coquelin at redhat.com>
> >> Subject: [PATCH v2] doc: introduce PVP reference benchmark
> >>
> >> Having reference benchmarks is important in order to obtain
> >> reproducible performance figures.
> >>
> >> This patch describes required steps to configure a PVP setup using
> >> testpmd in both host and guest.
> >>
> >> Not relying on external vSwitch ease integration in a CI loop by not
> >> being impacted by DPDK API changes.
> >>
> >> Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
> >
> > There is one trailing whitespace warning but apart from that:
> >
> > Acked-by: John McNamara <john.mcnamara at intel.com>
> 
> Thanks John,
> 
> Do you want me to send a v3, fixing the trailing whitespace & collecting
> the acks?
> 
>   -- Maxime


No need (unless the tree maintainer says otherwise). It was one trailing whitespace. Just something to look out for in future. 


P.S., We both should have truncated the text in this mail before replying. :-/

  http://dpdk.org/dev/patchwork/patch/17704/



More information about the dev mailing list