[dpdk-dev] [PATCH v1 2/5] app/testpmd: use ixgbe public functions
Iremonger, Bernard
bernard.iremonger at intel.com
Fri Dec 9 13:08:02 CET 2016
Hi Ferruh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, December 9, 2016 11:57 AM
> To: Iremonger, Bernard <bernard.iremonger at intel.com>;
> thomas.monjalon at 6wind.com; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1 2/5] app/testpmd: use ixgbe public
> functions
>
> On 12/9/2016 11:27 AM, Bernard Iremonger wrote:
> > Use the the following ixgbe public functions:
> >
> > rte_pmd_ixgbe_set_vf_rate_limit
> > rte_pmd_ixgbe_set_vf_rx
> > rte_pmd_ixgbe_set_vf_rxmode
> > rte_pmd_ixgbe_set_vf_tx
> > rte_pmd_ixgbe_set_vf_vlan_filter
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger at intel.com>
>
> <...>
>
> > @@ -2388,23 +2391,11 @@ int
> > set_vf_rate_limit(portid_t port_id, uint16_t vf, uint16_t rate,
> > uint64_t q_msk) {
> > int diag;
> > - struct rte_eth_link link;
> > -
> > - if (q_msk == 0)
> > - return 0;
> >
> > - if (port_id_is_invalid(port_id, ENABLED_WARN))
> > - return 1;
> > - rte_eth_link_get_nowait(port_id, &link);
> > - if (rate > link.link_speed) {
> > - printf("Invalid rate value:%u bigger than link speed: %u\n",
> > - rate, link.link_speed);
> > - return 1;
> > - }
>
> Why these changes required? Isn't only change is location and naming of the
> ...set_vf_rate_limit() ?
This change is a cleanup as the parameter checking is now done in rte_pmd_ixgbe_set_vf_rate_limit().
It was not possible to test the parameter checking in rte_pmd_ixgbe_set_vf_rate_limit() if the parameters were checked in the set_vf_rate_limit() function.
>
> > - diag = rte_eth_set_vf_rate_limit(port_id, vf, rate, q_msk);
> > + diag = rte_pmd_ixgbe_set_vf_rate_limit(port_id, vf, rate, q_msk);
> > if (diag == 0)
> > return diag;
> > - printf("rte_eth_set_vf_rate_limit for port_id=%d failed diag=%d\n",
> > + printf("rte_pmd_ixgbe_set_vf_rate_limit for port_id=%d failed
> > +diag=%d\n",
> > port_id, diag);
> > return diag;
> > }
> >
Regards,
Bernard.
More information about the dev
mailing list