[dpdk-dev] [PATCH v1 3/5] app/testpmd: add command for set VF VLAN filter

[Iremonger, Bernard]

Hi Ferruh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, December 9, 2016 12:03 PM
> To: Iremonger, Bernard <bernard.iremonger at intel.com>;
> thomas.monjalon at 6wind.com; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1 3/5] app/testpmd: add command for set
> VF VLAN filter
> 
> On 12/9/2016 11:27 AM, Bernard Iremonger wrote:
> > Add the following command to testpmd:
> > set vf vlan filter <port_id> <vlan_id> <vf_mask> <on|off>
> >
> > Add command to the testpmd user guide.
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger at intel.com>
> > ---
> 
> <...>
> 
> > +
> > +cmdline_parse_inst_t cmd_set_vf_vlan_filter = {
> > +	.f = cmd_set_vf_vlan_filter_parsed,
> > +	.data = NULL,
> > +	.help_str = "set vf vlan filter <port_id> <vlan_id> <vf_mask>
> > +<on_off>",
> 
> s/<on_off>/on|off
> 
> Only variables should be wrapped with "<>", fixed string with options can be
> used as a|b|c .
> 
> similar issues in other testpmd patches.
> 

I will fix in a v2.

Regards,

Bernard.