[dpdk-dev] [PATCH v1 0/5] net/ixgbe: move set VF functions.

Iremonger, Bernard bernard.iremonger at intel.com
Fri Dec 9 14:23:38 CET 2016


Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, December 9, 2016 1:05 PM
> To: Iremonger, Bernard <bernard.iremonger at intel.com>
> Cc: Yigit, Ferruh <ferruh.yigit at intel.com>; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1 0/5] net/ixgbe: move set VF functions.
> 
> 2016-12-09 12:00, Iremonger, Bernard:
> > From: Yigit, Ferruh
> > > Why this patchset doesn't remove ethdev updates for these functions?
> > >
> > > ixgbe is the only user for these eth-dev_ops, since code moved to
> > > ixgbe driver, they and relevant rte_eth_xx functions (and
> > > deprecation notice) can be removed in this patchset. Most probably
> > > after testpmd updated to prevent compilation errors.
> >
> > My understanding is that the functions should be copied and reworked
> before being removed from the ethdev, and that the removal should be
> done in a separate patch set.
> >
> > Hi Thomas,
> >
> > Could you clarify please.
> 
> It was announced that these functions will be removed, so they can be safely
> removed in 17.02, right?

Yes, it was announced in 16.11 that these functions will be removed so I believe they can be safely removed in17.02.

> In this case, it is a code move: copy, rework and delete in the same patch.
> And yes, the deprecation notice must be removed at the same time.


I will add the deletes in a v2 of the patchset.

Regards,

Bernard.




More information about the dev mailing list