[dpdk-dev] [PATCH v3] net/ixgbe:fix max packet length in ixgbevf

Yuanhan Liu yuanhan.liu at linux.intel.com
Wed Dec 14 08:06:21 CET 2016


On Thu, Dec 15, 2016 at 02:50:19AM +0800, Yi Zhang wrote:
> Current ixgbevf driver get max_rx_pktlen = 15872, but in fact PF
> supports 15872-byte jumbo frame and VF only supports 9728-byte jumbo
> frame. If VF is running DPDK driver and set frame_size > 9728 ,PF
> running kernel ixgbe driver will report an error and set VF failed.
> This patch fixs DPDK ixgbevf driver to get correct jumbo frame size
> of VF.
> 
> Signed-off-by: Yi Zhang <zhang.yi75 at zte.com.cn>

Hi,

I saw you have sent this patch 3 times; are you looking for review?
If so, you should not resend it many times, instead, you could reply
to your patch if it hasn't got any comments after one week, with
something like "some one can help review this?", or even a simple
"ping ..." might just work.

Besides that, you should Cc the corresponding maintainers, but not
"maintainer at some.org", which is just an example: I doubt such email
exists.

You could get the maintainers from the MAINTAINERS. Take ixgbe as
example, it's:

    Intel ixgbe
    M: Helin Zhang <helin.zhang at intel.com>
    M: Konstantin Ananyev <konstantin.ananyev at intel.com>
    F: drivers/net/ixgbe/
    F: doc/guides/nics/ixgbe.rst
    F: doc/guides/nics/intel_vf.rst

So for this patch, you should at least Cc (or To) Helin and Konstantin.
I have done that for you this time.

	--yliu
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index edc9b22..573252c 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3168,7 +3168,7 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
>  	dev_info->max_rx_queues = (uint16_t)hw->mac.max_rx_queues;
>  	dev_info->max_tx_queues = (uint16_t)hw->mac.max_tx_queues;
>  	dev_info->min_rx_bufsize = 1024; /* cf BSIZEPACKET in SRRCTL reg */
> -	dev_info->max_rx_pktlen = 15872; /* includes CRC, cf MAXFRS reg */
> +	dev_info->max_rx_pktlen = 9728; /* includes CRC, cf MAXFRS reg */
>  	dev_info->max_mac_addrs = hw->mac.num_rar_entries;
>  	dev_info->max_hash_mac_addrs = IXGBE_VMDQ_NUM_UC_MAC;
>  	dev_info->max_vfs = dev->pci_dev->max_vfs;
> -- 
> 2.9.3
> 


More information about the dev mailing list