[dpdk-dev] [PATCH v3 0/6] libeventdev API and northbound implementation

Shreyansh Jain shreyansh.jain at nxp.com
Mon Dec 19 06:16:32 CET 2016


My mail reader (thunderbird) is showing this series as a thread of "eal: 
postpone vdev initialization" patch series. Is it just me?

If it is a wrong 'in-reply-to', I think it should be corrected or people 
might not be able to search for this under right thread.

On Sunday 18 December 2016 07:51 PM, Jerin Jacob wrote:
> As previously discussed in RFC v1 [1], RFC v2 [2], with changes
> described in [3] (also pasted below), here is the first non-draft series
> for this new API.
>
> [1] http://dpdk.org/ml/archives/dev/2016-August/045181.html
> [2] http://dpdk.org/ml/archives/dev/2016-October/048592.html
> [3] http://dpdk.org/ml/archives/dev/2016-October/048196.html
>
> v2..v3:
>
> 1) Changed struct rte_event layout more aligment balanced(Harry, Jerin)
> 2) Changed event_ptr type to void* from uintptr_t(Bruce)
> 3) Changed ev[] as const in rte_event_enqueue_burst  to disallow
> drivers from modifying the events passed in(Bruce)
> 4) Removed queue memory allocation from common code as some drivers may not need
> it(Bruce)
> 5) Removed "struct rte_event_queue_link" and replaced with queues and priorities
> in the link and link_get API to avoid one redirection to use the API(Bruce)
>
> v1..v2:
> 1) Remove unnecessary header files from rte_eventdev.h(Thomas)
> 2) Removed PMD driver name(EVENTDEV_NAME_SKELETON_PMD) from rte_eventdev.h(Thomas)
> 3) Removed different #define for different priority schemes. Changed to
> one event device RTE_EVENT_DEV_PRIORITY_* priority (Bruce)
> 4) add const to rte_event_dev_configure(), rte_event_queue_setup(),
> rte_event_port_setup(), rte_event_port_link()(Bruce)
> 5) Fixed missing dev argument in dev->schedule() function(Bruce)
> 6) Changed \see to @see in doxgen comments(Thomas)
> 7) Added additional text in specification to clarify the queue depth(Thomas)
> 8) Changed wait to timeout across the specification(Thomas)
> 9) Added longer explanation for RTE_EVENT_OP_NEW and RTE_EVENT_OP_FORWARD(Thomas)
> 10) Fixed issue with RTE_EVENT_OP_RELEASE doxgen formatting(Thomas)
> 11) Changed to RTE_EVENT_DEV_CFG_FLAG_ from RTE_EVENT_DEV_CFG_(Thomas)
> 12) Changed to EVENT_QUEUE_CFG_FLAG_ from EVENT_QUEUE_CFG_(Thomas)
> 13) s/RTE_EVENT_TYPE_CORE/RTE_EVENT_TYPE_CPU/(Thomas, Gage)
> 14) Removed non burst API and kept only the burst API in the API specification
> (Thomas, Bruce, Harry, Jerin)
> -- Driver interface has non burst API, selection of the non burst API is based
> on num_objects == 1
> 15) sizeeof(struct rte_event) was not 16 in v1. Fixed it in v2
> -- reduced the width of event_type to 4bit to save space for future change
> -- introduced impl_opaque for implementation specific opaque data(Harry),
> Something useful for HW driver too, in the context of removal the need for sepeare
> release API.
> -- squashed other element size and provided enough space to impl_opaque(Jerin)
> -- added RTE_BUILD_BUG_ON(sizeof(struct rte_event) != 16); check
> 16) add union of uint64_t in the second element in struct rte_event to
> make sure the structure has 16byte address all arch(Thomas)
> 17) Fixed invalid check of nb_atomic_order_sequences in implementation(Gage)
> 18) s/EDEV_LOG_ERR/RTE_EDEV_LOG_ERR(Thomas)
> 19) s/rte_eventdev_pmd_/rte_event_pmd_/(Bruce)
> 20) added fine details of distributed vs centralized scheduling information
> in the specification and introduced RTE_EVENT_DEV_CAP_FLAG_DISTRIBUTED_SCHED
> flag(Gage)
> 21)s/RTE_EVENT_QUEUE_CFG_FLAG_SINGLE_CONSUMER/RTE_EVENT_QUEUE_CFG_FLAG_SINGLE_LINK (Jerin)
> to remove the confusion to between another producer and consumer in sw eventdev driver
> 22) Northbound api implementation  patch spited to more logical patches(Thomas)
>
> Changes since RFC v2:
>
> - Updated the documentation to define the need for this library[Jerin]
> - Added RTE_EVENT_QUEUE_CFG_*_ONLY configuration parameters in
>   struct rte_event_queue_conf to enable optimized sw implementation [Bruce]
> - Introduced RTE_EVENT_OP* ops [Bruce]
> - Added nb_event_queue_flows,nb_event_port_dequeue_depth, nb_event_port_enqueue_depth
>   in rte_event_dev_configure() like ethdev and crypto library[Jerin]
> - Removed rte_event_release() and replaced with RTE_EVENT_OP_RELEASE ops to
>   reduce fast path APIs and it is redundant too[Jerin]
> - In the view of better application portability, Removed pin_event
>   from rte_event_enqueue as it is just hint and Intel/NXP can not support it[Jerin]
> - Added rte_event_port_links_get()[Jerin]
> - Added rte_event_dev_dump[Harry]
>
> Notes:
>
> - This patch set is check-patch clean with an exception that
> 03/06 has one WARNING:MACRO_WITH_FLOW_CONTROL
> - Looking forward to getting additional maintainers for libeventdev
>
> TODO:
> 1) Create user guide
>
> Jerin Jacob (6):
>   eventdev: introduce event driven programming model
>   eventdev: define southbound driver interface
>   eventdev: implement the northbound APIs
>   eventdev: implement PMD registration functions
>   event/skeleton: add skeleton eventdev driver
>   app/test: unit test case for eventdev APIs
>
>  MAINTAINERS                                        |    5 +
>  app/test/Makefile                                  |    2 +
>  app/test/test_eventdev.c                           |  778 +++++++++++
>  config/common_base                                 |   14 +
>  doc/api/doxy-api-index.md                          |    1 +
>  doc/api/doxy-api.conf                              |    1 +
>  drivers/Makefile                                   |    1 +
>  drivers/event/Makefile                             |   36 +
>  drivers/event/skeleton/Makefile                    |   55 +
>  .../skeleton/rte_pmd_skeleton_event_version.map    |    4 +
>  drivers/event/skeleton/skeleton_eventdev.c         |  518 +++++++
>  drivers/event/skeleton/skeleton_eventdev.h         |   68 +
>  lib/Makefile                                       |    1 +
>  lib/librte_eal/common/include/rte_log.h            |    1 +
>  lib/librte_eventdev/Makefile                       |   57 +
>  lib/librte_eventdev/rte_eventdev.c                 | 1220 +++++++++++++++++
>  lib/librte_eventdev/rte_eventdev.h                 | 1407 ++++++++++++++++++++
>  lib/librte_eventdev/rte_eventdev_pmd.h             |  511 +++++++
>  lib/librte_eventdev/rte_eventdev_version.map       |   39 +
>  mk/rte.app.mk                                      |    5 +
>  20 files changed, 4724 insertions(+)
>  create mode 100644 app/test/test_eventdev.c
>  create mode 100644 drivers/event/Makefile
>  create mode 100644 drivers/event/skeleton/Makefile
>  create mode 100644 drivers/event/skeleton/rte_pmd_skeleton_event_version.map
>  create mode 100644 drivers/event/skeleton/skeleton_eventdev.c
>  create mode 100644 drivers/event/skeleton/skeleton_eventdev.h
>  create mode 100644 lib/librte_eventdev/Makefile
>  create mode 100644 lib/librte_eventdev/rte_eventdev.c
>  create mode 100644 lib/librte_eventdev/rte_eventdev.h
>  create mode 100644 lib/librte_eventdev/rte_eventdev_pmd.h
>  create mode 100644 lib/librte_eventdev/rte_eventdev_version.map
>



More information about the dev mailing list