[dpdk-dev] [PATCH v2 1/7] net/qede: reduce noise in debug logs

Ferruh Yigit ferruh.yigit at intel.com
Fri Dec 23 16:14:41 CET 2016


On 12/23/2016 12:48 AM, Harish Patil wrote:
> Move DP_NOTICE msg under CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO.
> 
> Signed-off-by: Harish Patil <harish.patil at qlogic.com>
> ---

<...>

>  
> -#ifdef RTE_LIBRTE_QEDE_DEBUG_DRIVER
> -#define PMD_DRV_LOG_RAW(level, fmt, args...) \
> -	RTE_LOG(level, PMD, "%s(): " fmt, __func__, ## args)
> -#else
> -#define PMD_DRV_LOG_RAW(level, fmt, args...) do { } while (0)
> -#endif
> -
>  #define PMD_DRV_LOG(level, fmt, args...) \
>  	PMD_DRV_LOG_RAW(level, fmt "\n", ## args)

This is now useless since PMD_DRV_LOG_RAW no more defined, I guess  this
doesn't give a compile error because PMD_DRV_LOG is not used at all in
the driver.
I think if PMD_DRV_LOG_RAW removed, PMD_DRV_LOG also should be removed.

>  
> 



More information about the dev mailing list