[dpdk-dev] [PATCH v5 20/20] ethdev: Decouple from PCI device

Jan Blunck jblunck at infradead.org
Fri Dec 23 17:20:39 CET 2016


On Fri, Dec 23, 2016 at 5:17 PM, Thomas Monjalon
<thomas.monjalon at 6wind.com> wrote:
> 2016-12-23 16:58, Jan Blunck:
>> +/**
>> + * @internal
>> + * Helper macro for drivers that need to convert to struct rte_pci_device.
>> + */
>> +#define RTE_DEV_PCI_DEV(ptr) container_of(ptr, struct rte_pci_device, device)
>
> Do you prefer to rename to RTE_DEV_TO_PCI?

I'm fine with that.

>
>> +       struct rte_device *device; /**< Backing device for this device */
>
> This comment looks strange.
> shorten to just "Backing device"?

Agreed.


More information about the dev mailing list