[dpdk-dev] [PATCH] nfp: avoid modulo operations for handling ring wrapping

Ferruh Yigit ferruh.yigit at intel.com
Fri Dec 23 17:25:56 CET 2016


On 12/19/2016 4:13 PM, Alejandro Lucero wrote:
> Having those modulo operations implies costly instructions execution,
> what can be avoided with conditionals and unlikely clauses.
> 
> This change makes the software ring read and write indexes to be now
> always within the ring size which has to be handled properly. The main
> problem is when write pointer wraps and being less than the read pointer.
> This happened before, but just with indexes type size (uint32_t) wrapping,
> and in that case the processor does the right thing no requiring special
> hanling by software.
> 
> This work has also led to discovering redundant pointers in the driver,
> which have been removed.
> 
> Signed-off-by: Alejandro Lucero <alejandro.lucero at netronome.com>

Applied to dpdk-next-net/master, thanks.


More information about the dev mailing list