[dpdk-dev] [PATCH 13/13] i40e: improve message grepability
Wu, Jingjing
jingjing.wu at intel.com
Wed Dec 28 04:51:56 CET 2016
> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michal Miroslaw
> Sent: Tuesday, December 13, 2016 9:08 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 13/13] i40e: improve message grepability
>
> Signed-off-by: Michał Mirosław <michal.miroslaw at atendesoftware.pl>
> ---
> drivers/net/i40e/i40e_ethdev.c | 198 +++++++++++++++--------------------------
> 1 file changed, 73 insertions(+), 125 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 39fbcfe..4d73aca 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -763,8 +763,7 @@ i40e_add_tx_flow_control_drop_filter(struct i40e_pf
> *pf)
> pf->main_vsi_seid, 0,
> TRUE, NULL, NULL);
> if (ret)
> - PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control "
> - " frames from VSIs.");
> + PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control
> frames
> +from VSIs.");
> }
You are right, it makes grep easily. But it will break the coding style "Line length is recommended to be not more than 80 characters, including comments."
Any comments from committers?
Thanks
Jingjing
More information about the dev
mailing list