[dpdk-dev] [PATCH] fm10k: enable PCIe port level Loopback Suppression

He, Shaopeng shaopeng.he at intel.com
Thu Feb 4 01:40:34 CET 2016


Hi Mark,

> -----Original Message-----
> From: Chen, Jing D
> Sent: Wednesday, February 03, 2016 3:18 PM
> To: He, Shaopeng; dev at dpdk.org
> Cc: Wang, Xiao W
> Subject: RE: [PATCH] fm10k: enable PCIe port level Loopback Suppression
> 
> Hi,
> 
> Best Regards,
> Mark
> 
> 
> > -----Original Message-----
> > From: He, Shaopeng
> > Sent: Thursday, January 28, 2016 1:49 PM
> > To: dev at dpdk.org
> > Cc: Chen, Jing D; Wang, Xiao W; He, Shaopeng
> > Subject: [PATCH] fm10k: enable PCIe port level Loopback Suppression
> >
> > A PCIe port may represent within it multiple logical ports
> > (for example when SR-IOV is enabled, or when a VMDQ type logical
> > port scheme is employed assigning ports to sets of queues).
> > For this reason each RX queue in each PCIe port is given a source
> > GLORT that is used for loopback suppression.
> > This patch assigns a SGLORT for each RX queue, and enables PCIe
> > port level Loopback Suppression.
> >
> 
> The log message is a little obscure for me. Maybe you can wrote:
> In FM10K, a single PF device can derive out a few logical ports, like SRIOV
> VF device, VMDQ object. To better manage them, FM10K silicon assigned a
> Unique GLORT ID to each logical ports.
> When a logical port sends a broadcast packet, the silicon will flood it to all
> Logical ports, including the one sent the broadcast packet. To prevent this,
> silicon has a rxq register to fill the glort id of the logical port that queue binds
> to....

Thanks for the suggestion, I will reword and send another version.

Thanks,
--Shaopeng
> 
> > Signed-off-by: Shaopeng He <shaopeng.he at intel.com>
> > ---
> >  drivers/net/fm10k/fm10k_ethdev.c | 18 +++++++++++++++++-
> >  1 file changed, 17 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/fm10k/fm10k_ethdev.c
> > b/drivers/net/fm10k/fm10k_ethdev.c
> > index f6eb05d..60f821a 100644
> > --- a/drivers/net/fm10k/fm10k_ethdev.c
> > +++ b/drivers/net/fm10k/fm10k_ethdev.c
> > @@ -690,12 +690,15 @@ static int
> >  fm10k_dev_rx_init(struct rte_eth_dev *dev)



More information about the dev mailing list