[dpdk-dev] [PATCH] virtio: prettify log messages

Stephen Hemminger stephen at networkplumber.org
Thu Feb 11 02:12:36 CET 2016


On Thu, 11 Feb 2016 00:45:34 +0100
Vincent JARDIN <vincent.jardin at 6wind.com> wrote:

> PMD_TX_LOG() looks better with a \n
> 
> Signed-off-by: Vincent JARDIN <vincent.jardin at 6wind.com>

NAK. Yes the messages, are messed up, but this is not
the right way to fix it.

The logging wrappers are inconsistent in virtio.
PMD_INIT_LOG adds newline, but RX/TX/DRV do not.

I would rather the macros were aligned with ixgbe which always
adds newline for all the PMD_XXX_LOG() macros. And then remove
all extra newlines in virtio code.


More information about the dev mailing list