[dpdk-dev] [PATCH v8 2/4] ethdev: Fill speed capability bitmaps in the PMDs

[Marc]

Rahul, Neilo, Jing D, et al

On 15 February 2016 at 15:43, Rahul Lakkireddy <rahul.lakkireddy at chelsio.com
> wrote:

> Hi Marc,
>
> On Sunday, February 02/14/16, 2016 at 23:17:37 +0100, Marc Sune wrote:
> > Added speed capabilities to all pmds supporting physical NICs:
> >
> > * e1000
> > * ixgbe
> > * i40
> > * bnx2x
> > * cxgbe
> > * mlx4
> > * mlx5
> > * nfp
> > * fm10k
> >
> > Signed-off-by: Marc Sune <marcdevel at gmail.com>
> > ---
> >  drivers/net/bnx2x/bnx2x_ethdev.c |  1 +
> >  drivers/net/cxgbe/cxgbe_ethdev.c |  1 +
> >  drivers/net/e1000/em_ethdev.c    |  6 ++++++
> >  drivers/net/e1000/igb_ethdev.c   |  6 ++++++
> >  drivers/net/fm10k/fm10k_ethdev.c |  4 ++++
> >  drivers/net/i40e/i40e_ethdev.c   |  9 +++++++++
> >  drivers/net/ixgbe/ixgbe_ethdev.c | 10 ++++++++++
> >  drivers/net/mlx4/mlx4.c          |  4 ++++
> >  drivers/net/mlx5/mlx5_ethdev.c   |  5 +++++
> >  drivers/net/nfp/nfp_net.c        |  2 ++
> >  10 files changed, 48 insertions(+)
> >
>
> [...]
>
> > diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c
> b/drivers/net/cxgbe/cxgbe_ethdev.c
> > index 97ef152..203e119 100644
> > --- a/drivers/net/cxgbe/cxgbe_ethdev.c
> > +++ b/drivers/net/cxgbe/cxgbe_ethdev.c
> > @@ -171,6 +171,7 @@ static void cxgbe_dev_info_get(struct rte_eth_dev
> *eth_dev,
> >
> >       device_info->rx_desc_lim = cxgbe_desc_lim;
> >       device_info->tx_desc_lim = cxgbe_desc_lim;
> > +     device_info->speed_capa = ETH_SPEED_CAP_10G | ETH_SPEED_CAP_40G;
> >  }
> >
>
> Not all Chelsio NICs support _both_ 10G and 40G speed capabilities on a
> single card.  You can query pi->link_cfg.supported to get the supported
> speeds.  Check out print_port_info() in cxgbe_main.c to help you fill
> in your speed capabilities for Chelsio NICs.
>

This patch series has been long delayed, and I've been requested to merge
it for next release if possible. Most of the feedback has been coming late
(not for cxgbe, which is introduced in this new v8, but it did for most of
the rest of drivers).

My proposal is simply to add in this patch series ALL possible speeds for
that driver. Other patches can be later submitted to adjust speeds
according to specific device model.

marc


>
> Thanks,
> Rahul
>