[dpdk-dev] [PATCH 2/3] ring: remove duplicate fields in internal data struct

[Bruce Richardson]

On Fri, Jan 29, 2016 at 05:16:21PM +0000, Ferruh Yigit wrote:
> 1- Remove duplicate nb_rx/tx_queues fields from internals
> 2- Remove data->rx/tx_queues allocation, whose auto allocated by
> libether
> 3- Remove duplicate data->rx/tx_queues[i] assignments
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---
>  drivers/net/ring/rte_eth_ring.c | 52 +++++++++++------------------------------
>  1 file changed, 14 insertions(+), 38 deletions(-)
> 

Hi Ferruh,

does this patch not break rte_eth_from_ring() and rte_eth_from_rings() since
the "auto allocation" you refer to is only performed on eth_dev_configure, I
believe. Currently, you can create an rte_ring and then use it as though it
were an ethdev by calling:
	port_id = rte_eth_from_ring(r)

With this change, I believe the user instead has to now call eth_from_ring,
then do a series of configure and queue setup calls just to make the new
ethdev usable.

Regards.
/Bruce