[dpdk-dev] [PATCH] eal:Change log output to DEBUG instead of INFO

Burakov, Anatoly anatoly.burakov at intel.com
Thu Feb 18 11:18:56 CET 2016


Hi

Apologies for late reply, was away. Can't comment on other lines, but

> > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > index 0e6c48a..e0c13de 100644
> > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > @@ -904,7 +904,7 @@ pci_vfio_enable(void)
> >
> >  	/* return 0 if VFIO modules not loaded */
> >  	if (module_vfio_type1 == 0) {
> > -		RTE_LOG(INFO, EAL, "VFIO modules not all loaded, "
> > +		RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, "
> >  			"skip VFIO support...\n");
> >  		return 0;
> >  	}
> >
> 

Should people be forced to recompile DPDK with debug logs (and get all this
additional debug output) just to see why VFIO doesn't get initialized? I would
argue this message is not as serious an annoyance to warrant this change, but
maybe Keith has a different opinion.

Either way, I don't feel strongly for or against the change.

Thanks,
Anatoly


More information about the dev mailing list