[dpdk-dev] [PATCH] eal:Change log output to DEBUG instead of INFO

Thomas Monjalon thomas.monjalon at 6wind.com
Thu Feb 18 15:08:49 CET 2016


2016-02-18 10:18, Burakov, Anatoly:
> > > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > > @@ -904,7 +904,7 @@ pci_vfio_enable(void)
> > >
> > >  	/* return 0 if VFIO modules not loaded */
> > >  	if (module_vfio_type1 == 0) {
> > > -		RTE_LOG(INFO, EAL, "VFIO modules not all loaded, "
> > > +		RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, "
> > >  			"skip VFIO support...\n");
> > >  		return 0;
> > >  	}
> 
> Should people be forced to recompile DPDK with debug logs (and get all this
> additional debug output) just to see why VFIO doesn't get initialized?

No, there is a run-time option --log-level.
The compiled max level must be set to DEBUG to be able to see this message
with debug --log-level.

> I would
> argue this message is not as serious an annoyance to warrant this change, but
> maybe Keith has a different opinion.
> 
> Either way, I don't feel strongly for or against the change.

Thanks


More information about the dev mailing list