[dpdk-dev] [PATCH 5/6] qede: add driver

Harish Patil harish.patil at qlogic.com
Tue Feb 23 20:04:28 CET 2016


>
>On Tue, 23 Feb 2016 02:28:25 +0000
>Harish Patil <harish.patil at qlogic.com> wrote:
>
>> All of the checkpatch warnings had been fixed  (except one which cannot
>>be
>> fixed) using the checkpatch script available under DPDK scripts/
>> directory. The linux checkpatch version is 0.32.
>> 
>> [root at dut4019 dpdk]# ./scripts/checkpatches.sh patches-send/*.patch
>> 
>> ### patches-send/0004-qede-add-driver-common-module.patch
>> 
>> WARNING:CAMELCASE: Avoid CamelCase: <inflateEnd>
>> #251: FILE: drivers/net/qede/ecore/bcm_osal.c:120:
>> +       inflateEnd(p_hwfn->stream);
>> 
>> total: 0 errors, 1 warnings, 54467 lines checked
>> 
>> Wouldn’t that suffice?
>
>Maybe your version of checkpatch from kernel is older than more recent
>version I am using (from Linux 4.4).
>
I had used checkpatch version 0.32 as mentioned above.
The latest checkpatch version in net-next also shows 0.32.
my $V = '0.32’;

I see similar checkpatch related conversations going on in other threads
in the distribution.
Please advise.
+Thomas

Thanks,
Harish 




More information about the dev mailing list