[dpdk-dev] [PATCH] config: remove duplicate configuration information

Wiles, Keith keith.wiles at intel.com
Wed Feb 24 16:25:43 CET 2016


>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wiles, Keith
>> Sent: Wednesday, February 24, 2016 1:58 PM
>> To: dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration
>> information
>> 
>> >In order to cleanup the configuration files some and reduce the number
>> >of duplicate configuration information. Add a new file called
>> >common_base which contains just about all of the configuration lines in
>> >one place. Then have the common_bsdapp, common_linuxapp files include
>> >this one file. Then in those OS specific files add the delta
>> >configuration lines.
>> >
>> >Signed-off-by: Keith Wiles <keith.wiles at intel.com>
>> 
>> Ping, Does this patch have any more comments, do we want to use this patch?
>
>I'd prefer to leave as is, but don't feel strongly about it, I can work with either way.
>Fiona

What are your reasons for leaving it the same other then just keeping something you know now?

I do not see any downside and the upside is reducing having to change multiple files for a configuration add/remove or modify. Also as Panu stated it makes the changes for each OS and configuration much more obvious.

As Panu gave a +1 is that a Ack or how is this handled?
>
>


Regards,
Keith






More information about the dev mailing list