[dpdk-dev] [PATCH 1/1] arm: set CONFIG_RTE_ARCH_STRICT_ALIGN=y for armv7 target
Jan Viktorin
viktorin at rehivetech.com
Mon Feb 29 18:13:27 CET 2016
On Mon, 29 Feb 2016 16:55:38 +0100
Jan Viktorin <viktorin at rehivetech.com> wrote:
> On Mon, 29 Feb 2016 16:14:58 +0100
> Thomas Monjalon <thomas.monjalon at 6wind.com> wrote:
>
> > 2015-12-09 16:16, Jan Viktorin:
> > > This patch reduces number of warnings from 53 to 40. It removes the usual false
> > > positives utilizing unaligned_uint*_t data types.
> > >
> > > Signed-off-by: Jan Viktorin <viktorin at rehivetech.com>
> >
> > Applied, thanks
> >
> > Jan, what is the problem with the other ARM alignment warnings?
> > Can they be fixed?
>
> This is the full list of warnings I can see on the current origin/master
> for ARMv7 (42 occurences) including examples (+10 more). The origin of
> all of them is:
>
> cast increases required alignment of target type [-Wcast-align]
>
> After skimming through the list, you can see that they are mostly casts
> to uint32_t * or something similar. I believe that all of them are OK.
> However, I don't know how to persuade GCC to not be angry...
>
> Probably, we can add some explicit alignment of certain structures.
>
[snip]
>
> lib/librte_vhost/vhost_user/virtio-net-user.c
> 433 rarp = (struct ether_arp *)(eth_hdr + 1);
> 527 ifr = (struct ifreq *)ifc.ifc_buf;
Fixed recently in
http://dpdk.org/browse/dpdk/commit/?id=bb66588304632a7e4a043d2921d06709d40f9ed4
>
> Regards
> Jan
More information about the dev
mailing list