[dpdk-dev] [PATCH 00/29] i40e base driver update

Zhang, Helin helin.zhang at intel.com
Sun Jan 17 14:43:49 CET 2016



> -----Original Message-----
> From: Richardson, Bruce
> Sent: Friday, January 15, 2016 6:48 PM
> To: Zhang, Helin
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 00/29] i40e base driver update
> 
> On Fri, Jan 15, 2016 at 10:40:24AM +0800, Helin Zhang wrote:
> > i40e base driver is updated, to support new X722 device IDs, and use
> > rx control AQ commands to read/write rx control registers.
> > Of cause, fixes and enhancements are added as listed as below.
> >
> > Helin Zhang (29):
> >   i40e/base: use explicit cast from u16 to u8
> >   i40e/base: Acquire NVM, before issuing an AQ read nvm command
> >   i40e/base: add hw flag for doing the SRCTL access using AQ for X722
> >   i40e/base: add changes in nvm read to support X722
> >   i40e/base: Limit DCB FW version checks to XL710/X710 devices
> >   i40e/base: check for stopped admin queue
> >   i40e/base: set aq count after memory allocation
> >   i40e/base: clean event descriptor before use
> >   i40e/base: add new device IDs and delete deprecated one
> >   i40e/base: fix up recent proxy and wol bits for X722_SUPPORT
> >   i40e/base: define function capabilities in only one place
> >   i40e/base: Fix for PHY NVM interaction problem
> >   i40e/base: set shared bit for multicast filters
> >   i40e/base: add APIs to Add/remove port mirroring rules
> >   i40e/base: add VEB stat control and remove L2 cloud filter
> >   i40e/base: implement the API function for aq_set_switch_config
> >   i40e/base: Add functions to blink led on Coppervale PHY
> >   i40e/base: When in promisc mode apply promisc mode to Tx Traffic as
> >     well
> >   i40e/base: Increase timeout when checking GLGEN_RSTAT_DEVSTATE bit
> >   i40e/base: Save off VSI resource count when updating VSI
> >   i40e/base: coding style fixes
> >   i40e/base: use FW to read/write rx control registers
> >   i40e/base: expose some registers to program parser, FD and RSS logic
> >   i40e/base: Add a Virtchnl offload for RSS PCTYPE V2
> >   i40e/base: add AQ thermal sensor control struct
> >   i40e/base: add/update structure and macro definitions
> >   i40e: add base driver release info
> >   i40e: add/remove new device IDs
> >   i40e: use rx control function for rx control registers
> 
> Couple of minor nits looking through the subject list above.
> * the promiscuous mode fix has too long a title, so please shorten (maybe
> drop the "when in promisc mode" bit)
> * some messages start with a capital letter, others not. They should be
> consistent and the standard is to not capitalize.
OK, I will have it reworked in the second version. Thanks a lot for the guidance!

Regards,
Helin

> 
> /Bruce


More information about the dev mailing list