[dpdk-dev] [PATCH 4/5] vhost: do not use rte_memcpy for virtio_hdr copy
Yuanhan Liu
yuanhan.liu at linux.intel.com
Wed Jan 27 04:22:45 CET 2016
On Wed, Jan 27, 2016 at 02:46:39AM +0000, Xie, Huawei wrote:
> On 12/3/2015 2:03 PM, Yuanhan Liu wrote:
> > + if (vq->vhost_hlen == sizeof(struct virtio_net_hdr_mrg_rxbuf)) {
> > + *(struct virtio_net_hdr_mrg_rxbuf *)(uintptr_t)desc_addr = hdr;
> > + } else {
> > + *(struct virtio_net_hdr *)(uintptr_t)desc_addr = hdr.hdr;
> > + }
>
> Thanks!
> We might simplify this further. Just reset the first two fields flags
> and gso_type.
What's this "simplification" for? Don't even to say that we will add
TSO support, which modifies few more files, such as csum_start: reseting
the first two fields only is wrong here.
--yliu
More information about the dev
mailing list