[dpdk-dev] [PATCH] lib: remove "extern" keyword for functions from header files

[Thomas Monjalon]

2016-01-25 10:01, Ferruh Yigit:
> Remove "extern" keywords in header files, the ones for function
> prototypes

I've seen a lot of other extern keywords. Why not removing all?

> -extern int rte_eth_dev_configure(uint8_t port_id,
> -				 uint16_t nb_rx_queue,
> -				 uint16_t nb_tx_queue,
> -				 const struct rte_eth_conf *eth_conf);
> +int rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_queue,
> +			  uint16_t nb_tx_queue,
> +			  const struct rte_eth_conf *eth_conf);

The indent is weird.
Why not follow the guideline with 2 tabs?
http://dpdk.org/doc/guides-2.2/contributing/coding_style.html#c-indentation