[dpdk-dev] [PATCH] Fix misleading indentation in ethtool

Ferruh Yigit ferruh.yigit at intel.com
Fri Jul 1 14:16:15 CEST 2016


On 7/1/2016 12:29 PM, De Lara Guarch, Pablo wrote:
> Hi Pengyu,
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pengyu Ma
>> Sent: Friday, July 01, 2016 9:53 AM
>> To: thomas.monjalon at 6wind.com; dev at dpdk.org
>> Subject: [dpdk-dev] [PATCH] Fix misleading indentation in ethtool
> 
> You need to add the library that you are fixing in the title:
> i.e. kni: fix misleading identation in ethtool
> 
> 
>>
>> gcc complains about:
>> build/lib/librte_eal/linuxapp/kni/e1000_phy.c:3303:2:
>> error: this 'if' clause does not guard... [-Werror=misleading-indentation]
> 
> Could you tell me which gcc version you are using?
> 
>>
>> Code indentation is misleadingly indented as whether
>> the following content is guarded by if or not.
>> With the reference of the context, add the curly braces.
>>
>> Remove unused const variables too.
> 
> You are fixing part of a library, so you should add a fixes line here.
> Please refer to the following document to know how to do it:
> http://dpdk.readthedocs.io/en/v16.04/contributing/patches.html
> 
>>
>> Signed-off-by: Pengyu Ma <pengyu.ma at windriver.com>
>> ---
>>  lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_phy.c     | 9 ++++++---
>>  lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_82599.c | 8 +++++---

Also these files fixed with following commit:
"cba50f6 kni: fix build with gcc 6"

Thank you for the patch, but it seems all issues addressed in this patch
already solved in master branch.

thanks,
ferruh



More information about the dev mailing list