[dpdk-dev] [PATCH 1/4] net/virtio-user: fix return value not checked
Yuanhan Liu
yuanhan.liu at linux.intel.com
Tue Jul 5 13:31:19 CEST 2016
On Tue, Jul 05, 2016 at 10:14:28AM +0000, Tan, Jianfeng wrote:
> > On Wed, Jun 29, 2016 at 09:05:33AM +0000, Jianfeng Tan wrote:
> > > - if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) == 1)
> > > - rte_kvargs_process(kvlist, VIRTIO_USER_ARG_CQ_NUM,
> > > - &get_integer_arg, &cq);
> > > + if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) == 1) {
> > > + ret = rte_kvargs_process(kvlist,
> > VIRTIO_USER_ARG_CQ_NUM,
> > > + &get_integer_arg, &cq);
> > > + if (ret < 0) {
> > > + PMD_INIT_LOG(ERR, "error to parse %s",
> > > + VIRTIO_USER_ARG_CQ_NUM);
> > > + goto end;
> > > + }
> > > + }
> > > else if (queues > 1)
> >
> > Above 2 lines should be in one line. Fixed, and series applied to
> > dpdk-next-virtio.
>
> Thanks.
>
> But there's another problem in the commit log: the Coverity defect ID should be "127477, 127478" instead of "127344, 127478". Can you please help make it right?
Done.
--yliu
More information about the dev
mailing list