[dpdk-dev] [PATCH v2 0/5] change lpm route table from code to data
Bruce Richardson
bruce.richardson at intel.com
Thu Jul 14 18:06:17 CEST 2016
This patchset takes the existing lpm large routing table information and
converts it from a header file included at compile time to a resource linked
in. This improves things in two ways:
1. Improves DPDK build time
2. Removes approx 1 million lines of code from our LOC counts, as the header
file no longer counts as code, but more correctly as data.
Before and after approx code stats (with some additional patchsets applied)
are given below. Notice how the app folder has dropped from being the biggest
component with 6x the drivers code to second place with less code than the
drivers.
Future work is to repeat the same process for lpm6. Additional work for both
lpm and lpm6 is to remove the routing tables entirely and replace them with
auto-generated data that gives the roughly the same results. That would
shrink the overall size of DPDK releases, and is the desired end state.
---
This patchset is based directly on the original RFC submitted:
http://www.dpdk.org/ml/archives/dev/2016-May/038478.html.
Updates in this version compared to RFC:
* rebased on dpdk.org HEAD. The changes are now mostly to test_lpm_perf.c
rather than test_lpm.c
* removed use of strndupa() as suggest by Nikita Koslov
---
## Before:
SLOC Directory SLOC-by-Language (Sorted)
1237464 app ansic=1236324,python=1140
192107 drivers ansic=192107
108109 lib ansic=107968,python=141
65447 examples ansic=65312,sh=135
849 tools python=444,sh=405
799 scripts sh=799
77 doc python=75,sh=2
0 config (none)
0 mk (none)
0 pkg (none)
0 top_dir (none)
Totals grouped by language (dominant language first):
ansic: 1601711 (99.80%)
python: 1800 (0.11%)
sh: 1341 (0.08%)
-----------
## After
SLOC Directory SLOC-by-Language (Sorted)
192107 drivers ansic=192107
160646 app ansic=159506,python=1140
108109 lib ansic=107968,python=141
65447 examples ansic=65312,sh=135
849 tools python=444,sh=405
799 scripts sh=799
77 doc python=75,sh=2
0 config (none)
0 mk (none)
0 pkg (none)
0 top_dir (none)
Totals grouped by language (dominant language first):
ansic: 524893 (99.41%)
python: 1800 (0.34%)
sh: 1341 (0.25%)
generated using David A. Wheeler's 'SLOCCount'
Bruce Richardson (5):
test: fix unneeded routes table include from lpm test
test: make all lpm routes be of unsigned type
test: add lpm routes as a linked resource
test: change lpm test to use routes as resource
test: change lpm routes file from header to data file
app/test/Makefile | 1 +
app/test/test_lpm.c | 2 +-
app/test/test_lpm_perf.c | 78 +++++++++++++++++++++-
.../{test_lpm_routes.h => test_lpm_routes.dat} | 2 +-
4 files changed, 80 insertions(+), 3 deletions(-)
rename app/test/{test_lpm_routes.h => test_lpm_routes.dat} (99%)
--
2.5.5
More information about the dev
mailing list