[dpdk-dev] [PATCH] test_mempool: remove unused mp_ext var

Olivier Matz olivier.matz at 6wind.com
Thu Jul 21 15:28:10 CEST 2016


Hi Santosh,

On 07/21/2016 01:49 PM, Santosh Shukla wrote:
> test_mempool func not using pointer variable 'mp_ext' and incorrectly freed. So
> removing ptr var. Now freeing mp_stack var.
> 
> Signed-off-by: Santosh Shukla <santosh.shukla at caviumnetworks.com>
> ---
>  app/test/test_mempool.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c
> index 46ad670..3b21cf7 100644
> --- a/app/test/test_mempool.c
> +++ b/app/test/test_mempool.c
> @@ -506,7 +506,6 @@ test_mempool(void)
>  {
>  	struct rte_mempool *mp_cache = NULL;
>  	struct rte_mempool *mp_nocache = NULL;
> -	struct rte_mempool *mp_ext = NULL;
>  	struct rte_mempool *mp_stack = NULL;
>  
>  	rte_atomic32_init(&synchro);
> @@ -605,7 +604,7 @@ test_mempool(void)
>  err:
>  	rte_mempool_free(mp_nocache);
>  	rte_mempool_free(mp_cache);
> -	rte_mempool_free(mp_ext);
> +	rte_mempool_free(mp_stack);
>  	return -1;
>  }
>  
> 

Strange, it seems these modifications were present in latest patch from
David Hunt (v6). Maybe a bad manipulation during the push?

The "Fixes:" line should be added though.

Acked-by: Olivier Matz <olivier.matz at 6wind.com>


More information about the dev mailing list