[dpdk-dev] [PATCH 02/12] virtio: setup and start cq in configure callback

Olivier Matz olivier.matz at 6wind.com
Fri Jul 22 09:54:01 CEST 2016



On 07/21/2016 11:15 PM, Stephen Hemminger wrote:
> On Thu, 21 Jul 2016 10:08:20 +0200
> Olivier Matz <olivier.matz at 6wind.com> wrote:
> 
>> +	dev_info->max_rx_queues = (uint16_t)
>> +		((VIRTIO_MAX_RX_QUEUES < hw->max_queue_pairs) ?
>> +			VIRTIO_MAX_RX_QUEUES : hw->max_queue_pairs);
>> +	dev_info->max_tx_queues = (uint16_t)
>> +		((VIRTIO_MAX_TX_QUEUES < hw->max_queue_pairs) ?
>> +			VIRTIO_MAX_TX_QUEUES : hw->max_queue_pairs);
> 
> cast here was always unnecessary.
> Why not use RTE_MIN()
> 

Yes, good idea, I'll do that for the v2.

Thanks,
Olivier


More information about the dev mailing list